-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CDN v5 endpoints to use RFC3339 timestamps #7549
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7549 +/- ##
=============================================
- Coverage 65.05% 29.83% -35.23%
Complexity 98 98
=============================================
Files 314 794 +480
Lines 12365 84864 +72499
Branches 907 905 -2
=============================================
+ Hits 8044 25318 +17274
- Misses 3968 57416 +53448
- Partials 353 2130 +1777
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 473 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2ffc68f
to
8ee45c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified Locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM and comments have been addressed.
This PR updates the
cdns
v5 TO endpoints to returnlastUpdated
in the format ofRFC3339
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Query the CRUD CDNs endpoint in API version 5 to confirm RFC3339 format, also query version 4 to confirm the time format has not changed.
PR submission checklist