-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traffic Portal v2 Topologies details page #7615
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrhoffman
added
new feature
A new feature, capability or behavior
Traffic Portal v2
Related to the experimental Traffic Portal version 2
labels
Jul 5, 2023
zrhoffman
force-pushed
the
tpv2-topologies-details
branch
from
July 5, 2023 15:45
dc7711f
to
fec15af
Compare
ocket8888
added
low impact
affects only a small portion of a CDN, and cannot itself break one
experimental
a feature/component not directly supported by ATC
labels
Jul 5, 2023
zrhoffman
force-pushed
the
tpv2-topologies-details
branch
from
July 13, 2023 13:03
b549806
to
7ca64c8
Compare
Codecov Report
@@ Coverage Diff @@
## master #7615 +/- ##
=============================================
+ Coverage 28.97% 67.09% +38.12%
Complexity 98 98
=============================================
Files 739 266 -473
Lines 82332 10130 -72202
Branches 908 952 +44
=============================================
- Hits 23855 6797 -17058
+ Misses 56435 3061 -53374
+ Partials 2042 272 -1770
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 489 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ocket8888
requested changes
Jul 17, 2023
experimental/traffic-portal/src/app/api/testing/topology.service.ts
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/api/testing/topology.service.ts
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/api/testing/topology.service.ts
Outdated
Show resolved
Hide resolved
experimental/traffic-portal/src/app/api/testing/topology.service.ts
Outdated
Show resolved
Hide resolved
...mental/traffic-portal/src/app/core/topologies/topology-details/topology-details.component.ts
Outdated
Show resolved
Hide resolved
...ntal/traffic-portal/src/app/core/topologies/topology-details/topology-details.component.html
Outdated
Show resolved
Hide resolved
...ntal/traffic-portal/src/app/core/topologies/topology-details/topology-details.component.html
Outdated
Show resolved
Hide resolved
...ntal/traffic-portal/src/app/core/topologies/topology-details/topology-details.component.html
Outdated
Show resolved
Hide resolved
...ntal/traffic-portal/src/app/core/topologies/topology-details/topology-details.component.html
Outdated
Show resolved
Hide resolved
zrhoffman
force-pushed
the
tpv2-topologies-details
branch
from
July 25, 2023 14:55
e5fe801
to
1cce76e
Compare
ocket8888
requested changes
Jul 27, 2023
ocket8888
reviewed
Jul 27, 2023
...l/traffic-portal/src/app/core/topologies/topology-details/topology-details.component.spec.ts
Outdated
Show resolved
Hide resolved
ocket8888
requested changes
Jul 31, 2023
experimental/traffic-portal/src/app/api/testing/topology.service.ts
Outdated
Show resolved
Hide resolved
...ntal/traffic-portal/src/app/core/topologies/topology-details/topology-details.component.html
Outdated
Show resolved
Hide resolved
zrhoffman
force-pushed
the
tpv2-topologies-details
branch
from
July 31, 2023 22:51
caa9612
to
03f16c0
Compare
Rebased onto master |
ocket8888
requested changes
Aug 1, 2023
...ntal/traffic-portal/src/app/core/topologies/topology-details/topology-details.component.html
Outdated
Show resolved
Hide resolved
ocket8888
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
experimental
a feature/component not directly supported by ATC
low impact
affects only a small portion of a CDN, and cannot itself break one
new feature
A new feature, capability or behavior
Traffic Portal v2
Related to the experimental Traffic Portal version 2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Topologies details page to Traffic Portal v2 with the following restrictions:
Depends on
apache/trafficcontrol-trafficops-types#4(merged)Which Traffic Control components are affected by this PR?
PR submission checklist