t3c to use package metadata if rpm db is unhealthy #7652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7652 +/- ##
=============================================
- Coverage 65.10% 27.20% -37.90%
Complexity 98 98
=============================================
Files 314 686 +372
Lines 12359 79755 +67396
Branches 905 90 -815
=============================================
+ Hits 8046 21701 +13655
- Misses 3961 55984 +52023
- Partials 352 2070 +1718
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 587 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ocket8888
added
bug
traeak
approved these changes
Jul 20, 2023
ocket8888
reviewed
Jul 20, 2023
ocket8888
requested changes
Jul 25, 2023
ocket8888
approved these changes
Jul 26, 2023
jagan-parthiban
pushed a commit
to jagan-parthiban/trafficcontrol
that referenced
this pull request
Jul 27, 2023
* adding check to verify rpmdb * added check to verify rpm db * rebase and fix conflicts * if rpmdb is unhealthy use package data in metadata * requested changes addressed. * added changelog entry * fixed spelling error and added GoDoc commnet * fixed formatting error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now if there is an issue with RPM t3c will not be able keep the cache config up to date. this PR will address this issue.
In syncds mode t3c will attempt a check of the RPM DB files, if it succeeds t3c will continue as normal. if the check fails t3c will attempt to get package data from t3c-apply-metadata.json. if package data is available t3c will use it and make an assumption that trafficserver is installed and continue with config updates. if the package data in the metadata file is unavailable it will attempt to continue without package data.
if badass mode or --install-packages=true is selected. t3c will exit with an error if rpm db check fails as packages cannot be installed without rpm.
Which Traffic Control components are affected by this PR?
t3c, formerly ORT)What is the best way to verify this PR?
since it is difficult and dangerous to corrupt an rpm database the best way to test is update the config such that rpmDBisOk is set to false run t3c in different modes and check the results.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist