Tpv2 logging overhaul #7673
Merged
Tpv2 logging overhaul #7673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
added
low impact
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ocket8888
force-pushed
the
tpv2/server-logging-overhaul
branch
from
69a32a5
to
51e65ff
Compare
Codecov Report
@@ Coverage Diff @@
## master #7673 +/- ##
=============================================
+ Coverage 29.78% 65.60% +35.82%
Complexity 98 98
=============================================
Files 802 323 -479
Lines 85789 12829 -72960
Branches 952 965 +13
=============================================
- Hits 25550 8417 -17133
+ Misses 58099 4051 -54048
+ Partials 2140 361 -1779
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 483 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ocket8888
force-pushed
the
tpv2/server-logging-overhaul
branch
2 times, most recently
from
30de8f1
to
2fd08e4
Compare
shamrickus
requested changes
Jul 31, 2023
ocket8888
force-pushed
the
tpv2/server-logging-overhaul
branch
from
2fd08e4
to
d6dba19
Compare
shamrickus
requested changes
Aug 3, 2023
experimental/traffic-portal/src/app/shared/import-json-txt/import-json-txt.component.ts
Outdated
Show resolved
Hide resolved
Because they're exported from utils, so the import wouldn't stutter in most cases even if you decide to import the whole module as a namespace (for whatever reason).
this simplifies it a bit and also switched to using fs/promises which is a bit faster
Also removes some try/catch blocks that appeared to be concealing test failures?
Also alphabetically sorted the declarations for the core module - we were declaring a few things multiple times.
Makes use of the utils package to avoid the need for 'as' statements
limited success on that front
…onses in some cases
Made it like 14x faster on my machine - I was a real idiot to not do that in the first place.
ocket8888
force-pushed
the
tpv2/server-logging-overhaul
branch
from
2e31dbc
to
4cef64e
Compare
cybertunnel
pushed a commit
to cybertunnel/trafficcontrol
that referenced
this pull request
Aug 16, 2023
* Add a logging class * re-name things to include a Log prefix Because they're exported from utils, so the import wouldn't stutter in most cases even if you decide to import the whole module as a namespace (for whatever reason). * Add middleware for logging and error handling * Move file compression stuff into middleware this simplifies it a bit and also switched to using fs/promises which is a bit faster * rework TO proxy handler to use a logger * Add a front-end logging service * fixup allowed console methods now that there's a logger * Fix linting errors arising from not using loggers * Remove console calls from tests Also removes some try/catch blocks that appeared to be concealing test failures? * fix non-camelCase component naming Also alphabetically sorted the declarations for the core module - we were declaring a few things multiple times. * Simplify type guards in server configuration Makes use of the utils package to avoid the need for 'as' statements * Add typing for a Node SystemError * Fix incorrect use of logging middleware * Try to clean up some errors being hit in the SSR handler limited success on that front * fix directory handle leak * Make non-production server builds debug-able * add initial debug log for all requests, fix double-writing error responses in some cases * Move "time elapsed" debug message so that non-error responses also log it * Remove duplicated check, extraneous substring argument * Fix missing `req` option to SSR engine handler * Update a lot of fs access to be asynchronous * Fix hard-coded VERSION file path * Cache file compressions instead of recalculating on every request Made it like 14x faster on my machine - I was a real idiot to not do that in the first place. * Fix lint errors from rebasing * Make regexp non-polynomial * Fix comment grammar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls the way TPv2 does logging to be more consistent. At present, it's not configurable, it just omits debug-level messages if it's in a production environment. The idea was primarily to add it to the server, which had sparse and opaque logging, but a logging service was also added to the UI to allow for a consistent logging format there. Really all that does is add timestamps to everything (so far).
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure the tests pass, look at the server logs and see if the format looks good.
PR submission checklist