TO API v5 routes should not use priv levels anymore #7819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7819 +/- ##
============================================
+ Coverage 28.93% 31.89% +2.95%
Complexity 98 98
============================================
Files 602 719 +117
Lines 77379 82789 +5410
Branches 90 970 +880
============================================
+ Hits 22392 26408 +4016
- Misses 52890 54215 +1325
- Partials 2097 2166 +69
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 120 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ocket8888
added
Traffic Ops
zrhoffman
requested changes
Sep 27, 2023
traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go
Outdated
Show resolved
Hide resolved
traffic_ops/traffic_ops_golang/deliveryservice/servers/servers.go
Outdated
Show resolved
Hide resolved
ocket8888
reviewed
Sep 27, 2023
zrhoffman
requested changes
Sep 28, 2023
zrhoffman
approved these changes
Sep 28, 2023
rimashah25
pushed a commit
that referenced
this pull request
Oct 3, 2023
* TO API v5 routes should not use priv levels anymore * add changelog * fix tests, cleanup * remove commented out code * code review * rename perm constants (cherry picked from commit 5081509)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is not related to any issue. It makes sure that api v5 routes in traffic ops are no longer using
privLevelcomparisons.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure all unit/ e2e tests pass.
5.0 routes should still work as expected, with capabilities being honored, instead of the privilege levels.
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist