Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go version to 1.23.1 #8073

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Update Go version to 1.23.1 #8073

merged 1 commit into from
Sep 13, 2024

Conversation

asf-ci-trafficcontrol
Copy link
Contributor

What does this PR (Pull Request) do?

This PR makes the Go components of Traffic Control build using Go version 1.23.1 and updates the golang.org/x/ dependencies.

See the Go 1.23.1 release notes:

go1.23.1 (released 2024-09-05) includes security fixes to the encoding/gob, go/build/constraint, and go/parser packages, as well as bug fixes to the compiler, the go command, the runtime, and the database/sql, go/types, os, runtime/trace, and unique packages. See the Go 1.23.1 milestone on our issue tracker for details.

Which Traffic Control components are affected by this PR?

  • Traffic Control Cache Config (t3c, formerly ORT)
  • Traffic Control Health Client (tc-health-client)
  • Traffic Control Client
  • Traffic Monitor
  • Traffic Ops
  • Traffic Stats
  • Grove
  • CDN in a Box - Enroller
  • CI tests for Go components
  • Build system - Go version in builder images

What is the best way to verify this PR?

Run unit tests and API tests. Since this is only a patch-level version update, the only changes were bugfixes. Breaking changes would be unexpected.

The following criteria are ALL met by this PR

  • Existing tests are sufficient, no additional tests necessary
  • The documentation only mentions the major Go version, no documentation updates necessary.
  • The changelog already mentions updating to Go 1.23, no additional changelog message necessary.
  • This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY (see the Apache Software Foundation's security guidelines for details)

@zrhoffman zrhoffman merged commit f647d58 into master Sep 13, 2024
38 checks passed
@zrhoffman zrhoffman deleted the go-1.23.1 branch September 13, 2024 16:39
rimashah25 pushed a commit to rimashah25/trafficcontrol that referenced this pull request Sep 27, 2024
Co-authored-by: asf-ci-trafficcontrol <[email protected]>

(cherry picked from commit f647d58)
rimashah25 pushed a commit to rimashah25/trafficcontrol that referenced this pull request Sep 27, 2024
Co-authored-by: asf-ci-trafficcontrol <[email protected]>

(cherry picked from commit f647d58)
zrhoffman added a commit that referenced this pull request Sep 27, 2024
* Updated version

* Updated changelog

* Use `docker compose` plugin (#8056)

* docker-compose -> docker compose

Excludes Dockerfile-tsb and the vendor directory.

    sed -i 's/docker-compose /docker compose /g' $(git grep -l 'docker-compose ')
    pattern="$(<<'PATTERN' cat
    docker-compose\($\|['`"*,)]\)
    PATTERN
    )"
    sed -i "s/${pattern}/docker compose\1/g" -- $(git grep -l "$pattern")
    sed -i 's/"docker compose"/"docker", "compose"/g' $(git grep -Fl '"docker compose"')

* Remove version from compose files.

sed -i '/^version:/d' $(git grep -il '^version:' '*docker-compose*.y*ml')

* Include `--all` in docker-compose ps command.

This is necessary for the plugin version of docker compose to query
exited containers.

* Changelog entry

* Support docker compose fallback for older docker versions that do not
have the compose plugin

* Improve PUT /deliveryservice_request_comments id (#8071)

* Update actions/upload-artifact and actions/download-artifact to v4 (#8081)

Fixes message:
This request has been automatically failed because it uses a deprecated
version of `actions/upload-artifact: v2`. Learn more:
https://github.blog/changelog/2024-02-13-deprecation-notice-v1-and-v2-of-the-artifact-actions/

* Update Postgres version to 13.16 (#8079)

* Use :atc-postgres-version: role in documentation

* Get postgres version from .env in Traffic Ops spec file

* Get POSTGRES_VERSION from .env in Dockerfiles and docker-compose files

* Update Postgres version to 13.16

* Update Trafficserver Alpine image to 9.2.4 (#7994)

* No substitution in the name

* Download ATS from the Apache archive

download.apache.org only contains currently-supported releases.

* Use Alpine main repo version 3.16 for adding package libexecinfo-dev

Alpine versions above 3.16 do not contain package libexecinfo-dev, which
ATS needs.

Alpine 3.19 still fails for unknown reasons, but Alpine 3.18 builds with
this fix.

* Set default for GITHUB_REPOSITORY

* Update Apache Traffic Server to 9.2.4

(cherry picked from commit 14007e3)

* Update Go version to 1.23.1 (#8073)

Co-authored-by: asf-ci-trafficcontrol <[email protected]>

(cherry picked from commit f647d58)

* Update Chromedriver Versions (#8084)

Update chromedriver

(cherry picked from commit 289c2c3)

* Update Go version to 1.22.5 (#8034)

* Update Go version to 1.22.5

* Update some images to Rocky Linux 8

---------

Co-authored-by: asf-ci-trafficcontrol <[email protected]>
Co-authored-by: Zach Hoffman <[email protected]>

(cherry picked from commit 0b21b43)

* Update changelog-1 and ciab.yml

* Update Go version to 1.23.1 (#8073)

Co-authored-by: asf-ci-trafficcontrol <[email protected]>

(cherry picked from commit f647d58)

---------

Co-authored-by: Zach Hoffman <[email protected]>
Co-authored-by: asf-ci-trafficcontrol <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants