Memory map: mmap+memcopy instead pread+pwrite #11484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making the PR against the master branch. Should #10832 be closed? |
|
Yes #10832 should be closed. As per the comment, it has been merged into the master branch. |
|
[approve ci] |
|
@monkuta Please run |
|
Changes have been made. (6df2474) |
JosiahWI
reviewed
Jun 28, 2024
|
@monkuta Do you have benchmarking number without and with this change? |
|
@bryancall |
moonchen
requested changes
Jul 15, 2024
src/iocore/aio/AIO.cc
Outdated
| #endif | ||
| } else { | ||
| #ifdef AIO_FAULT_INJECTION | ||
| err = aioFaultInjection.pwrite(a->aio_fildes, (static_cast<char *>(a->aio_buf)) + res, a->aio_nbytes - res, | ||
| a->aio_offset + res); | ||
| #else | ||
| #if TS_USE_MMAP | ||
| ink_assert((static_cast<char const *>(a->aio_fildes.first) + a->aio_offset + a->aio_nbytes) <= a->aio_fildes.last); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for only-in-memory caching for usecases where such behavior is needed (i.e. Live Video caching). It maps storage directly into user space memory, so reads and writes are being done by a memcpy (without calls to io).
To build:
cmake -B build -DENABLE_HWLOC=ON -DENABLE_MMAP=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF
cmake --build build -j
cmake --install build