WICKET-7075: Only support headers on uncommitted response #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solomax
approved these changes
Sep 19, 2023
martin-g
requested changes
Sep 19, 2023
|
@martin-g certainly, though I don't believe I have an account for the ASF JIRA yet so this may take a bit |
|
We/I can help with the creation of the ticket if you like! |
|
I've only run into this problem with the milestone 1 release for version 10 when run on Jetty 12 though, so the 9.x releases are somewhat less relevant to my situation I suppose. So thanks for the offer, but it's probably best if I create the ticket myself so I include all relevant background information. |
|
I've created https://issues.apache.org/jira/browse/WICKET-7075. I'll amend the commit to include the ticket number |
CrossOriginOpenerPolicyRequestCycleListener attempts to write headers to a response that is already committed. It contains logic to prevent setting of headers when a response does not support them, but the implementation for ServletWebResponse always returns true. This commit modifies ServletWebResponse to check if the underlying HttpServletResponse has already been committed.
jsteenbeeke
changed the title
martin-g
approved these changes
Sep 19, 2023
|
Thank you, @jsteenbeeke ! |
martin-g
pushed a commit
that referenced
this pull request
Jan 23, 2024
CrossOriginOpenerPolicyRequestCycleListener attempts to write headers to a response that is already committed. It contains logic to prevent setting of headers when a response does not support them, but the implementation for ServletWebResponse always returns true. This commit modifies ServletWebResponse to check if the underlying HttpServletResponse has already been committed. (cherry picked from commit de89eb6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CrossOriginOpenerPolicyRequestCycleListener attempts to write headers to a response that is already committed. It contains logic to prevent setting of headers when a response does not support them, but the implementation for ServletWebResponse always returns true.
This PR modifies ServletWebResponse to check if the underlying HttpServletResponse has already been committed.