[WICKET-7072] wicket tester and core tests #660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wicket does not use maven-site-plugin since a long time Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
martin-g
force-pushed
the
WICKET-7072-wicket-tester-and-core-tests
branch
from
adc79f9 to
d6897c4
Compare
…dule Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
bitstorm
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
I tested the branch running all test case in wicket-core-test from Eclipse and everything worked fine. Still have the problem with ApacheLicenseHeaderTestCase but that's fine as reported by @gluser1357
|
@gluser1357 this one also can be closed? |
|
IMO yes, this PR can be closed (since replaced by #666). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here another one (still not a merge canditate, see WICKET-7072 with wicket tester and core tests libs.