[YUNIKORN-1842] improve updatePVCRefCounts #629
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #629 +/- ##
==========================================
+ Coverage 70.84% 71.07% +0.23%
==========================================
Files 50 50
Lines 8194 8177 -17
==========================================
+ Hits 5805 5812 +7
+ Misses 2186 2164 -22
+ Partials 203 201 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
FrankYang0529
force-pushed
the
YUNIKORN-1842
branch
from
b18afcc
to
2ea7cb7
Compare
craigcondit
requested changes
Jul 12, 2023
| maxGeneration = node.Generation | ||
| func (cache *SchedulerCache) updatePVCRefCounts(node *framework.NodeInfo, removeNode bool) { | ||
| for k, v := range cache.pvcRefCounts { | ||
| delete(v, node.Node().Name) |
There was a problem hiding this comment.
Save node.Node().Name to a variable at the top of the function so it can be re-used.
There was a problem hiding this comment.
Updated it. Thank you!
Signed-off-by: Frank Yang <[email protected]>
FrankYang0529
force-pushed
the
YUNIKORN-1842
branch
from
2ea7cb7
to
3b3234e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In the previous version, we call
updatePVCRefCountsinupdateNode,updatePod, andremovePod. These functions callNodeInfo.SetNode,NodeInfo.AddPod, orNodeInfo.RemovePod. All theseNodeInfofunctions updateGeneration, so I think we don't need to usepvcGenerationto determine whether we need to updatepvcRefCounts. We can just givenodeInfoobject toupdatePVCRefCountsand updatepvcRefCountsinSchedulerCache.What type of PR is it?
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1842
How should this be tested?
Add unit tests for
updatePVCRefCountsScreenshots (if appropriate)
Questions: