Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YUNIKORN-2845] Remove SchedulerConf.TestMode #923

Closed
wants to merge 1 commit into from

Conversation

pbacsko
Copy link
Contributor

@pbacsko pbacsko commented Oct 9, 2024

What is this PR for?

Remove SchedulerConf.TestMode because it's no longer needed.

What type of PR is it?

  • - Bug Fix
  • - Improvement
  • - Feature
  • - Documentation
  • - Hot Fix
  • - Refactoring

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2845

How should this be tested?

Screenshots (if appropriate)

Questions:

  • - The licenses files need update.
  • - There is breaking changes for older versions.
  • - It needs documentation.

@pbacsko pbacsko self-assigned this Oct 9, 2024
@pbacsko pbacsko marked this pull request as draft October 9, 2024 14:35
Copy link
Contributor

@craigcondit craigcondit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM, pending rebase and tests passing.

@pbacsko pbacsko marked this pull request as ready for review October 9, 2024 15:42
@pbacsko pbacsko changed the title [DRAFT] [YUNIKORN-2845] Remove SchedulerConf.TestMode [YUNIKORN-2845] Remove SchedulerConf.TestMode Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.28%. Comparing base (4d6b4de) to head (1612d8c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #923      +/-   ##
==========================================
+ Coverage   68.21%   68.28%   +0.06%     
==========================================
  Files          70       70              
  Lines        7621     7611      -10     
==========================================
- Hits         5199     5197       -2     
+ Misses       2214     2205       -9     
- Partials      208      209       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pbacsko pbacsko closed this in 32903ff Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants