Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(laravel): eloquent accessors #6668

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

soyuka
Copy link
Member

@soyuka soyuka commented Sep 24, 2024

Q A
Branch? 4.0
Tickets Closes #6644
License MIT

Fixes #6644 @toitzi may you review?

@toitzi
Copy link
Contributor

toitzi commented Sep 24, 2024

@soyuka yes, it does fix the issue, however i think instead of this, fixing the underlaying Metadata class (see this pr) might be the better approach here. (Maybe merge those 2 Pr's - his code changes and your unittests)

@soyuka
Copy link
Member Author

soyuka commented Sep 25, 2024

#6633 is definitely good but we should merge both as we can't know what's in this array for sure I think its best to define defaults values as it triggers a Fatal Error (500) and I'd like to avoid this anyways.

@soyuka soyuka merged commit 2b4937a into api-platform:4.0 Sep 26, 2024
58 of 59 checks passed
soyuka added a commit to soyuka/core that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants