fix(symfony): fetch api-platform/symfony version debug bar #6722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix/6709
branch
2 times, most recently
from
f5b9a50
to
a945940
Compare
dunglas
reviewed
Oct 14, 2024
| @@ -73,7 +73,16 @@ public function getVersion(): ?string | |||
| return null; | |||
| } | |||
|
|
|||
| $version = Versions::getVersion('api-platform/core'); | |||
| try { | |||
| $version = Versions::getVersion('api-platform/core'); | |||
There was a problem hiding this comment.
In the end, almost all users will upgrade to api-platform/symfony, so we should test it first to prevent a useless catch.
soyuka
force-pushed
the
fix/6709
branch
4 times, most recently
from
54de22d
to
639e898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6709