fix(serializer): hal serializer detecting and handling circular reference #6752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentin-dassonville
force-pushed
the
fix/hal-circular-reference
branch
2 times, most recently
from
f2935b4
to
e4ead18
Compare
valentin-dassonville
changed the title
valentin-dassonville
force-pushed
the
fix/hal-circular-reference
branch
from
810a1ce
to
4208096
Compare
dunglas
approved these changes
Oct 25, 2024
valentin-dassonville
force-pushed
the
fix/hal-circular-reference
branch
2 times, most recently
from
287c0a2
to
d3efc4a
Compare
|
I think we should target 3.4 as a bug fix |
soyuka
force-pushed
the
fix/hal-circular-reference
branch
from
d3efc4a
to
ce6f3b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hal serializer didn't detect circular references, creating an infinite json.
Now Hal's
ItemNormalizercan detect and handle this case.