fix(metadata): providing parameter constraints skips automatic ones #6756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
According to the documentation https://api-platform.com/docs/core/filters/#parameter-validation, we can read:
Then, given the following simplified resource definition:
I would expect that the
NotNull
constraint automatically provided by therequired
parameter is not provided anymore as I define custom constraint.If you mind why the required parameter is defined here, it's for forcing the required flag in the Open API documentation.
Here, a PR proposing a fix on the 4.0 branch, not sure if the bug is present on the 3.x branch or the main branch as my project use the 4.x branch currently and the class modified in this PR seems not existing on these branches.
If you agree about this fix, I can take some time to add tests about it.