-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: implement admin permissions #429
Draft
vincentchalamon
wants to merge
3
commits into
4.0
Choose a base branch
from
fix/admin-permissions
base: 4.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,9 @@ | ||
import { expect, test } from "./test"; | ||
|
||
test.describe("User authentication", () => { | ||
test.beforeEach(async ({ bookPage }) => { | ||
test("I can sign out of Admin @login", async ({ bookPage, page }) => { | ||
await bookPage.gotoList(); | ||
}); | ||
|
||
test("I can sign out of Admin @login", async ({ userPage, page }) => { | ||
await page.getByLabel("Profile").click(); | ||
await page.getByRole("menu").getByText("Logout").waitFor({ state: "visible" }); | ||
await page.getByRole("menu").getByText("Logout").click(); | ||
|
@@ -21,4 +19,21 @@ test.describe("User authentication", () => { | |
await expect(page.locator("#kc-form-login")).toContainText("Login as user: [email protected]"); | ||
await expect(page.locator("#kc-form-login")).toContainText("Login as admin: [email protected]"); | ||
}); | ||
|
||
test("I see a permission denied error page if I don't have the right permissions @login", async ({ userPage, page }) => { | ||
await userPage.goToAdminWithInvalidUser(); | ||
|
||
await expect(page.locator("#forbidden")).toContainText("You are not allowed to access this page."); | ||
await page.getByLabel("Profile").click(); | ||
await page.getByRole("menu").getByText("Logout").waitFor({ state: "visible" }); | ||
await page.getByRole("menu").getByText("Logout").click(); | ||
|
||
await expect(page).toHaveURL(/\/$/); | ||
|
||
// I should be logged out from Keycloak also | ||
await page.goto("/admin"); | ||
await page.waitForURL(/\/oidc\/realms\/demo\/protocol\/openid-connect\/auth/); | ||
// @ts-ignore assert declared on test.ts | ||
await expect(page).toBeOnLoginPage(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,24 @@ | ||
import { AbstractPage } from "./AbstractPage"; | ||
|
||
export class UserPage extends AbstractPage { | ||
public async goToAdminWithInvalidUser() { | ||
await this.registerMock(); | ||
|
||
await this.page.goto("/admin"); | ||
await this.loginWithPublicUser(); | ||
await this.page.waitForURL(/\/admin#\/admin/); | ||
|
||
return this.page; | ||
} | ||
|
||
public async loginWithPublicUser() { | ||
await this.page.getByLabel("Email").fill("[email protected]"); | ||
await this.page.getByLabel("Password").fill("Pa55w0rd"); | ||
await this.page.getByRole("button", { name: "Sign In" }).click(); | ||
if (await this.page.getByRole("button", { name: "Sign in with Keycloak" }).count()) { | ||
await this.page.getByRole("button", { name: "Sign in with Keycloak" }).click(); | ||
} | ||
|
||
return this.page; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usePermissions can only be called by children of react-admin's
<Admin>
component (otherwise there is no AuthProviderContext and QueryClientContext available). That's why you have an error.The proper fix would be to call the
usePermissions
inBookList
and other admin-only components, and redirect to a/forbidden
CustomRoute if the permissions don't match.