-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature DocSearch V3 #327
Merged
alanpoulain
merged 10 commits into
api-platform:main
from
natacha-h:feature-DocSearch-v3
Oct 4, 2022
Merged
feature DocSearch V3 #327
alanpoulain
merged 10 commits into
api-platform:main
from
natacha-h:feature-DocSearch-v3
Oct 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
requested changes
Sep 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!! I made some minor comments but otherwise, it looks good to me!
Co-authored-by: Kévin Dunglas <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
Co-authored-by: Kévin Dunglas <[email protected]>
dunglas
approved these changes
Sep 27, 2022
LGTM |
alanpoulain
reviewed
Oct 3, 2022
Co-authored-by: Alan Poulain <[email protected]>
alanpoulain
approved these changes
Oct 3, 2022
Fabious
reviewed
Oct 4, 2022
Co-authored-by: Fabien Kovacic <[email protected]>
natacha-h
added a commit
to natacha-h/api-plaform-website
that referenced
this pull request
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used DocSearch v3 React component (installed as dependency), modified css in new file _docsearchcustom.scss, added appID in .env.gatsby