Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature DocSearch V3 #327

Merged
merged 10 commits into from
Oct 4, 2022
Merged

Conversation

natacha-h
Copy link
Contributor

Q A
Branch? feature-DocSearch-v3
Tickets #325
License MIT

Used DocSearch v3 React component (installed as dependency), modified css in new file _docsearchcustom.scss, added appID in .env.gatsby

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!! I made some minor comments but otherwise, it looks good to me!

.env.gatsby Show resolved Hide resolved
.env.gatsby Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/layout/Search.js Outdated Show resolved Hide resolved
src/components/layout/Search.js Outdated Show resolved Hide resolved
@natacha-h natacha-h marked this pull request as ready for review September 30, 2022 09:32
@Fabious
Copy link
Contributor

Fabious commented Oct 3, 2022

LGTM

@alanpoulain alanpoulain merged commit 51e1bd5 into api-platform:main Oct 4, 2022
natacha-h added a commit to natacha-h/api-plaform-website that referenced this pull request Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants