Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to sway 2 by bumping dep version and fixing tests #139

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

idanw206
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@idanw206
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@idanw206 idanw206 mentioned this pull request Aug 29, 2018
@chrislukkk
Copy link

@theganyo any plan to roll this out? thanks!

@idanw206
Copy link
Author

idanw206 commented Oct 4, 2018

@theganyo can you please respond? thanks!

@maziyarpanahi
Copy link

There are tons of fixes in Sway 2.0 and some relate to array type which really required. I also would appreciate this release as well.
Thanks

@meisterlampe
Copy link

Same here. Really need the fixes for arrays with a single element only. Please update the lib.

@idanw206
Copy link
Author

Can any of you check this out?
@earth2marsh @gbrail @theganyo @whitlockjc @WWitman

@maziyarpanahi
Copy link

If you are really in need for the latest pull requests you can use my fork and I have already merged the pull requests which I am using it in my production:
https://github.com/multivacplatform/swagger-node-runner

Use it like this:

"swagger-express-runner": "[email protected]:multivacplatform/swagger-node-runner.git",

Or you can fork it yourself and do the changes. Either way, when the maintainer comes back you can switch to the original repo with no problem.
Hope this helps.

@adityaguru149
Copy link

@theganyo Can we get this in? This seems to solve CVE-2018-3750
@earth2marsh @gbrail @whitlockjc @WWitman Anyone?

@robert-claypool
Copy link

@adityaguru149
Copy link

I went ahead and created npm packages to solve this.
https://www.npmjs.com/package/swagger-express-mw1
https://www.npmjs.com/package/swagger-node-runner1

These are based on forked repo from https://github.com/multivacplatform/swagger-node-runner
Thanks to @maziyarpanahi

We can use these for now and wait for apigee-127 to fix the original package

@maziyarpanahi
Copy link

Great! Many thanks @adityaguru149 👍

@svsg-dmitrib
Copy link

@camsjams
Copy link
Contributor

camsjams commented Aug 1, 2019

Do the contributors of this project need help? This has been ignored for a while - I can help if anything is needed as I would like this fix as well. AKA bump

@camsjams
Copy link
Contributor

camsjams commented Aug 1, 2019

Since I've looked at this thread more than once, I figured I would help future people out, please see:
How to migrate a Node JS Express project out of Swagger-Express

Note: I am not associated with either project but just wanted to share a migration guide.

@WaldoJeffers
Copy link

WaldoJeffers commented Oct 27, 2021

Any chance to see this merged? This would really help a lot of people, and would likely require no changes in swagger-node-runner 🤔 cc @theganyo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants