-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add path groups #37
Add path groups #37
Conversation
This is awesome!! Ready to merge? |
Ready from my end. I was hoping to get this into a new grandcypher release and require that version or greater when using it with txtai. This feature is going to enable this functionality: neuml/txtai#540 |
Groovy — will merge now! |
Actually — before I do... Any interest in adding yourself to the changelog to collect your internet points? Otherwise, I can do it after we merge :) |
Sure. I can push another commit with a change log update for 0.6.0. I'll also update setup.py. |
Just pushed the updated CHANGELOG and bumped version in setup.py |
Initial implementation of #26 as discussed in #35.
After thinking about how a standard node and relationship are returned, this initial implementation mirrors that for paths.
For example:
Returns:
With this change:
Returns:
[node id1, {relationship attributes} node id2]
The plumbing is now in place to return the data in whatever format we think makes sense.
I think I modified the lark spec to make the path_clause optional. The tests pass.