Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pagination] Support nodes in Connection types #5754

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Mar 21, 2024

Fix for #5735.

@BoD BoD requested a review from martinbonnin as a code owner March 21, 2024 16:40
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit ad5c50b
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/65fd58a51aed8e0008c92174

Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions:

For those kinds of things that are iterating quickly and where tagging new versions of directives is cumbersome, what about a "draft" version like there is for the GraphQL spec?

@BoD
Copy link
Contributor Author

BoD commented Mar 22, 2024

Do we want to make a new version of apollographql/specs@main/kotlin_labs/v0.2/kotlin_labs-v0.2.graphql ?
Is it ok that connectionFields applies to both standard connections and non-standard ones? The risk of name clash is probably low but still.

I think it's ok to keep only connectionFields - with this change, we merge edges and nodes if present. So it's more like a extra thing that it does. If a nodes field is present and is not a list, it will be ignored, so I think it's not too risky.

I like the idea of having a draft version of the spec though - I can set this up.

@BoD BoD merged commit 01e6ca5 into main Mar 25, 2024
9 checks passed
@BoD BoD deleted the pagination-relay-nodes branch March 25, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants