fix: parse JSON body when Content-Type has charset #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slagiewka: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
slagiewka
force-pushed
the
handle_content_type_extra_charset
branch
2 times, most recently
from
3eb471b to
c6a9eaa
Compare
|
@trevor-scheer please have a look 🙂 |
Or other parameters. In accordance with RFC 9110[^1], Content-Type contains first and foremost the media type. It can be followed by key-value pairs of parameters. This change supports extracting the media type and effectively discarding the other parameters as these are currently irrelevant to body parsing. The result media type is then matched against previously used JSON type tests. Closes apollographql#229 Closes apollographql#341 [^1]:https://www.rfc-editor.org/rfc/rfc9110.html
slagiewka
force-pushed
the
handle_content_type_extra_charset
branch
from
c6a9eaa to
f5378ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Or other parameters.
In accordance with RFC 91101, Content-Type contains first and
foremost the media type. It can be followed by key-value pairs of
parameters.
This change supports extracting the media type and effectively
discarding the other parameters as these are currently irrelevant to
body parsing. The result media type is then matched against previously
used JSON type tests.
Closes #229
Closes #341
Footnotes
https://www.rfc-editor.org/rfc/rfc9110.html ↩