-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update the Dependencies section #848
Conversation
README.md
Outdated
- [Newtonsoft.Json](http://www.nuget.org/packages/Newtonsoft.Json/) | ||
- [Selenium.Support](https://www.nuget.org/packages/Selenium.Support/) | ||
- [Castle.Core](https://www.nuget.org/packages/Castle.Core/) | ||
- [System.Text.Json](https://www.nuget.org/packages/System.Text.Json/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this here? As this project, this deps is maybe for testing only
<PackageReference Include="System.Text.Json" Version="8.0.5" /> |
I'm wondering if this deps can have a link to https://github.com/appium/dotnet-client/blob/main/src/Appium.Net/Appium.Net.csproj simply for product code, and test code is dotnet-client/test/integration/Appium.Net.Integration.Tests.csproj instead of listening all of them here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, removed System.Text.Json
.
Regarding the link, I can add the following link which will show the NuGet dependencies
https://www.nuget.org/packages/Appium.WebDriver/absoluteLatest#dependencies-body-tab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KazuCocoa, so what's your call, Add the link to NuGet dependencies tab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either is fine. I mean maintaining the deps here as well, or leaving the link only so that we don't need to keep reflecting the deps
List of changes
Please provide a briefly described change list that you are going to propose.
Types of changes
What types of changes are you proposing/introducing to the .NET client?
Put an
x
in the boxes that applyDocumentation
This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example
Integration tests
Details
Please provide more details about changes if necessary. You can provide code samples showing how they work and possible use cases if there are new features. Also, you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub