Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove MultiAction and TouchAction #960

Merged
merged 4 commits into from
Feb 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,15 @@ For example, some changes in the Selenium binding could break the Appium client.
> to keep compatible version combinations.


### Quick migration guide from v3 to v4
- Removal
- `MultiAction` and `TouchAction` are removed. Please use W3C WebDriver actions or `mobile:` extensions
- [appium/webdriver/extensions/action_helpers.py](appium/webdriver/extensions/action_helpers.py)
- https://www.selenium.dev/documentation/webdriver/actions_api/
- https://www.youtube.com/watch?v=oAJ7jwMNFVU
- https://appiumpro.com/editions/30-ios-specific-touch-action-methods
- https://appiumpro.com/editions/29-automating-complex-gestures-with-the-w3c-actions-api

### Quick migration guide from v2 to v3
- `options` keyword argument in the `webdriver.Remote` constructor such as `XCUITestOptions` instead of `desired_capabilities`
- Available options are https://github.com/appium/python-client/tree/master/appium/options
Expand All @@ -83,12 +92,6 @@ For example, some changes in the Selenium binding could break the Appium client.
- Added `strict_ssl` to relax SSL errors such as self-signed ones
- Deprecated
- `MultiAction` and `TouchAction` are deprecated. Please use W3C WebDriver actions or `mobile:` extensions
- e.g.
- [appium/webdriver/extensions/action_helpers.py](appium/webdriver/extensions/action_helpers.py)
- https://www.selenium.dev/documentation/webdriver/actions_api/
- https://www.youtube.com/watch?v=oAJ7jwMNFVU
- https://appiumpro.com/editions/30-ios-specific-touch-action-methods
- https://appiumpro.com/editions/29-automating-complex-gestures-with-the-w3c-actions-api
- `launch_app`, `close_app`, and `reset` are deprecated. Please read [issues#15807](https://github.com/appium/appium/issues/15807) for more details

#### MultiAction/TouchAction to W3C actions
Expand Down
99 changes: 0 additions & 99 deletions appium/webdriver/common/multi_action.py

This file was deleted.

218 changes: 0 additions & 218 deletions appium/webdriver/common/touch_action.py

This file was deleted.

2 changes: 1 addition & 1 deletion ci-jobs/functional_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,6 @@ jobs:
name: 'func_test_android8'
vmImage: ${{ parameters.vmImage }}
pytestOpt: ${{ parameters.pytestOpt }}
testFiles: 'network_connection_tests.py log_event_tests.py activities_tests.py hw_actions_tests.py touch_action_tests.py'
testFiles: 'network_connection_tests.py log_event_tests.py activities_tests.py hw_actions_tests.py'
sdkVer: ${{ parameters.androidSdkVer }}
CI: ${{ parameters.ci }}
16 changes: 0 additions & 16 deletions docs/webdriver.common.rst
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,6 @@ webdriver.common.mobileby module
:undoc-members:
:show-inheritance:

webdriver.common.multi\_action module
-------------------------------------

.. automodule:: webdriver.common.multi_action
:members:
:undoc-members:
:show-inheritance:

webdriver.common.touch\_action module
-------------------------------------

.. automodule:: webdriver.common.touch_action
:members:
:undoc-members:
:show-inheritance:

Module contents
---------------

Expand Down
Loading
Loading