Add github action support #542
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madrob
reviewed
Jul 1, 2024
Comment on lines
+50
to
+52
| - name: Set up Docker Buildx | ||
| uses: docker/setup-buildx-action@v1 | ||
| - uses: docker/setup-buildx-action@v3 |
There was a problem hiding this comment.
Is this right that we set up twice?
madrob
reviewed
Jul 1, 2024
| run: | | ||
| echo "matrix=$(python3 .github/workflows/set_matrix.py)" >> $GITHUB_OUTPUT | ||
|
|
||
| build-and-test: |
There was a problem hiding this comment.
Is there a way to set the name here to something nicer than the list of files? I'm imagining build-and-test (1/10) and then first step can be to echo list of files to output for debugging later?
|
@madrob Thanks for the feedback! I probably won't be able to attend to this PR for a few weeks. Feel free to take make a separate PR and discard this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing here until GHA is enabled on axlearn: samos123#1
The GHA are working except clip_test.py seems to be broken but I suspect it's broken on circleCI too.
I would prefer to merge this with excluding clip_test.py. I or the whoever wrote/knows clip_test.py can do a follow up PR.