Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarifying the default function name field for multifunction in the docs #2246

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Clarifying the default function name field for multifunction in the docs #2246

wants to merge 1 commit into from

Conversation

DawerG
Copy link
Collaborator

@DawerG DawerG commented Jun 18, 2024

No description provided.

@DawerG DawerG force-pushed the dev/gdawer/clarify-multifunction-doc branch from d937e9d to bab1c5f Compare June 18, 2024 19:20
jakesabathia2
jakesabathia2 reviewed Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@jakesabathia2 jakesabathia2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!
I think it would also be good to make the doc in these two places more clear:

  1. https://apple.github.io/coremltools/source/coremltools.models.html#coremltools.models.utils.MultiFunctionDescriptor
  2. https://apple.github.io/coremltools/source/coremltools.models.html#coremltools.models.model.MLModel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakesabathia2 jakesabathia2 jakesabathia2 left review comments

@aseemw aseemw aseemw approved these changes

@TobyRoseman TobyRoseman Awaiting requested review from TobyRoseman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DawerG @aseemw @jakesabathia2