Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random seed in --help output #220

Open
svenkevs opened this issue Jul 29, 2023 · 1 comment
Open

Random seed in --help output #220

svenkevs opened this issue Jul 29, 2023 · 1 comment

Comments

@svenkevs
Copy link

Not a big issue, very minor actually.

When running the --help argument (swift run StableDiffusionSample --help) the generated documentation calculates a random seed each time, and passes the result of the RNG as the default seed option.

The documentation implies that you have to provide some argument with --seed in order to get a random number, or otherwise it will provide the shown 'default value'. While this should be the other way around.

Run 1:
--seed Random seed (default: 3944433010)
Run 2:
--seed Random seed (default: 1029080931)
Run n:
--seed Random seed (default: 769278928)

svenkevs added a commit to svenkevs/ml-stable-diffusion that referenced this issue Jul 29, 2023
See issue: apple#220

When running the --help argument (swift run StableDiffusionSample --help) the generated documentation calculates a random seed each time, and passes the result of the RNG as the default seed option.

The documentation implies that you have to provide some argument with --seed in order to get a random number, or otherwise it will provide the shown 'default value'. While this should be the other way around.

Run 1:
--seed Random seed (default: 3944433010)
Run 2:
--seed Random seed (default: 1029080931)
Run n:
--seed Random seed (default: 769278928)
@svenkevs
Copy link
Author

svenkevs commented Jul 29, 2023

Made a pull request for a small improvement on the help output: #221

@svenkevs svenkevs mentioned this issue Jul 29, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant