Update main.swift #221
Open
Update main.swift #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See issue: apple#220 When running the --help argument (swift run StableDiffusionSample --help) the generated documentation calculates a random seed each time, and passes the result of the RNG as the default seed option. The documentation implies that you have to provide some argument with --seed in order to get a random number, or otherwise it will provide the shown 'default value'. While this should be the other way around. Run 1: --seed Random seed (default: 3944433010) Run 2: --seed Random seed (default: 1029080931) Run n: --seed Random seed (default: 769278928)
alejandro-isaza
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue: #220
When running the --help argument (swift run StableDiffusionSample --help) the generated documentation calculates a random seed each time, and passes the result of the RNG as the default seed option.
The documentation implies that you have to provide some argument with --seed in order to get a random number, or otherwise it will provide the shown 'default value'. While this should be the other way around.
Run 1:
--seed Random seed (default: 3944433010)
Run 2:
--seed Random seed (default: 1029080931)
Run n:
--seed Random seed (default: 769278928)