Error occurs when processing files with Japanese names #653
Comments
|
Definitely a bug, thanks for the report! |
HT154
added a commit
to HT154/pkl
that referenced
this issue
Oct 16, 2024
If AstBuilder is processing UnaryMinus -> UnaryMinus -> IntLiteral, the "inner" UnaryMinus helpfully defers inversion to the IntLiteral and returns it directly. The "_outer_" UnaryMinus, none the wiser, then does the exact same thing. There needs to be a way to force only the inner-most UnaryMinus to delegate to the literal node, which seems tricky in context. This is my (relatively naive) attempt at that, but this feels messy. I think there's also a possible overflow edge case around minInt. More than happy to take suggestions on a better way to handle this! Closes apple#653
HT154
added a commit
to HT154/pkl
that referenced
this issue
Oct 16, 2024
If AstBuilder is processing UnaryMinus -> UnaryMinus -> IntLiteral, the "inner" UnaryMinus helpfully defers inversion to the IntLiteral and returns it directly. The "_outer_" UnaryMinus, none the wiser, then does the exact same thing. There needs to be a way to force only the inner-most UnaryMinus to delegate to the literal node, which seems tricky in context. This is my (relatively naive) attempt at that, but this feels messy. I think there's also a possible overflow edge case around minInt. More than happy to take suggestions on a better way to handle this! Closes apple#653
Merged
HT154
added a commit
to HT154/pkl
that referenced
this issue
Oct 16, 2024
If AstBuilder is processing UnaryMinus -> UnaryMinus -> IntLiteral, the "inner" UnaryMinus helpfully defers inversion to the IntLiteral and returns it directly. The "_outer_" UnaryMinus, none the wiser, then does the exact same thing. There needs to be a way to force only the inner-most UnaryMinus to delegate to the literal node, which seems tricky in context. This is my (relatively naive) attempt at that, but this feels messy. I think there's also a possible overflow edge case around minInt. More than happy to take suggestions on a better way to handle this! Closes apple#653
HT154
added a commit
to HT154/pkl
that referenced
this issue
Oct 16, 2024
If AstBuilder is processing UnaryMinus -> UnaryMinus -> IntLiteral, the "inner" UnaryMinus helpfully defers inversion to the IntLiteral and returns it directly. The "_outer_" UnaryMinus, none the wiser, then does the exact same thing. There needs to be a way to force only the inner-most UnaryMinus to delegate to the literal node, which seems tricky in context. This is my (relatively naive) attempt at that, but this feels messy. I think there's also a possible overflow edge case around minInt. More than happy to take suggestions on a better way to handle this! Closes apple#653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was trying to use the
pklcommand to process files with Japanese names. However, an error occurs when attempting to evaluate the file.Information for Bug Report
Steps to Reproduce
Check the version of
pkl:Create a file
en.pkland check the content:$ cat en.pkl name = ""Evaluate the file with
pkl:Copy the file and rename it to a Japanese name:
Attempt to evaluate the Japanese-named file:
The text was updated successfully, but these errors were encountered: