-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of file:
module URIs with non-ASCII characters
#696
base: main
Are you sure you want to change the base?
Conversation
df9ec5a
to
2d75e6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
We should also fix this in org.pkl.core.module.FileResolver#listElements(java.net.URI)
, and org.pkl.core.module.FileResolver#hasElement(java.net.URI)
.
That would handle cases like:
read("file:///path/to/日本語.pkl")
I refactored this into I suspect most other usage of |
pkl-core/src/test/files/LanguageSnippetTests/output/basic/readGlob.pcf
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending CI checks.
You need to run ./gradlew spotlessApply
to fix some formatting woes.
Hmm I think this may be a legitimate difference in how things are handled on different OSs:
Is there a way to provide a different expectation or exclude this particular test on Windows? Or would it be best to just move this to |
Let me look into that one for you; I have access to a Windows machine so it's much easier for me to figure this one out. |
Resolves #653