codegen-kotlin: Support Java serialization of module classes #721
+192
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zable for abstract classes Motivation: Don't generate code that isn't useful. Changes: - Don't generate equals/hashCode/toString/copy methods for abstract classes. - Don't make abstract classes serializable. Result: - Less code is generated. - Fixes apple#713. Note: codegen-java does the same for stateless classes, but it also makes them non-instantiable. codegen-kotlin generates stateless regular classes far less often than codegen-java.
- use `assertContains()` instead of `assertThat().contains()` - remove redundant `trimIndent()` and `trimMargin()` calls - rename `javaCode` to `kotlinCode`
translatenix
force-pushed
the
kotlin-module-serializable
branch
from
6023f1b
to
db32e2a
Compare
Motivation: - Java serialization makes as much sense for module classes as it does for regular classes. - Offer same Java serialization support as codegen-java. Changes: - Move generation of `appendProperty` method and serialization code into new method `generateCompanionRelatedCode`. - Improve/fix generation of serialization code. Result: Java serialization is also supported for module classes.
translatenix
force-pushed
the
kotlin-module-serializable
branch
from
db32e2a
to
9c5dbbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #714.
Motivation:
Changes:
appendPropertymethod and serialization codeinto new method
generateCompanionRelatedCode.Result:
Java serialization is also supported for module classes.