Skip to content

Commit

Permalink
Make memset_s consistent with Darwin. (#52)
Browse files Browse the repository at this point in the history
Resolves [issue#51](#51).

In Swift 5.3, a warning is viewed on Linux because `memset_s` implemented in this module returns `Void`.
This commit let the function return the same type with Darwin.
  • Loading branch information
YOCKOW authored Oct 6, 2020
1 parent 3c632a6 commit 9680b72
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion Sources/Crypto/Util/BoringSSL/Zeroization_boring.swift
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,15 @@
#if !(os(macOS) || os(iOS) || os(watchOS) || os(tvOS))
@_implementationOnly import CCryptoBoringSSL

typealias errno_t = CInt

// This is a Swift wrapper for the libc function that does not exist on Linux. We shim it via a call to OPENSSL_cleanse.
// We have the same syntax, but mostly ignore it.
func memset_s(_ s: UnsafeMutableRawPointer!, _ smax: Int, _ byte: CInt, _ n: Int) {
@discardableResult
func memset_s(_ s: UnsafeMutableRawPointer!, _ smax: Int, _ byte: CInt, _ n: Int) -> errno_t {
assert(smax == n, "memset_s invariant not met")
assert(byte == 0, "memset_s used to not zero anything")
CCryptoBoringSSL_OPENSSL_cleanse(s, smax)
return 0
}
#endif

0 comments on commit 9680b72

Please sign in to comment.