Rename _CryptoExtras to CryptoExtras #281
Conversation
| @@ -79,7 +79,8 @@ let package = Package( | |||
| ], | |||
| products: [ | |||
| .library(name: "Crypto", targets: ["Crypto"]), | |||
| .library(name: "_CryptoExtras", targets: ["_CryptoExtras"]), | |||
| .library(name: "_CryptoExtras", targets: ["CryptoExtras"]), | |||
There was a problem hiding this comment.
One for discussion - the README is set up that this library won't exist but I've left it here for discussion if we want to keep it to maintain backwards compatibility or not or release this with the upcoming major version
There was a problem hiding this comment.
I think retaining the backward compatibility is valuable: while the underscore is present, we've tried to avoid gratuitously breaking things and it'd be nice to do so here.
There was a problem hiding this comment.
Ok I've updated the README. In terms of getting this to work with CMake do I need an shim for _CryptoExtras that points to CryptoExtras?
|
One thing this PR doesn't currently change is the CMake files - will wait to hear if it should be a breaking or backwards compatible change first |
|
I'm going to suggest we slow-roll this until we've had the conversation about the best name for this module. |
Rename
_CryptoExtrastoCryptoExtrasChecklist
If you've made changes to
gybfiles.script/generate_boilerplate_files_with_gyband included updated generated files in a commit of this pull requestMotivation:
CryptoExtras is now depended on by a number of libraries and well used and well understood. This PR formalises this with the removal of the underscore to the product to denote it's now a 'real' library
Modifications:
Renamed the product
Result:
import _CryptoExtrasis nowimport CryptoExtras