Use Serialization instead of JSONEncoder in recordArgument() #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm hm, yes I think that's right -- we should always go through the serialization infra like that, good call! |
|
@swift-server-bot test this please |
|
Failure: #1089 |
ktoso
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Int arguments were serialized as Strings, but the deserializer expected bytes. I found these commented lines of code that seemed to be the correct way of serializing instead of using JSONEncoder, but I'm not sure if that is true. If it is, I guess the reason these were comments might still apply, but it does work in my simple application and all tests are successful.