Add Sendable conformances (except FileDescriptor) #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milseman
approved these changes
Nov 12, 2022
|
@swift-ci please test |
|
@lorentey is there any further availability dance needed for these? |
|
I don't think so -- the Sendable conformance will be back deployable as it has no ABI impact! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
Sendableconformances to all public types, as well as the necessary internal types (SystemStringandSystemChar).Whether or not
FileDescriptorshould be Sendable is currently being discussed in #112.This PR splits off
FileDescriptors conformance to have the possibility to land the other conformances earlier.