Skip to content

Commit

Permalink
Odoo 16 Storage: Fix loading wrong partner in get (#206)
Browse files Browse the repository at this point in the history
`list` already loads correct partner
  • Loading branch information
bastjan authored May 17, 2024
1 parent e4164a1 commit 73a7e02
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions apiserver/billing/odoostorage/odoo/odoo16/odoo16.go
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ func (s *Odoo16Storage) get(ctx context.Context, name string) (company odooclien
}

cpp, err := session.FindResPartners(
odooclient.NewCriteria().AddCriterion(activeFilter).AddCriterion(odooclient.NewCriterion("id", "=", id)),
odooclient.NewCriteria().AddCriterion(activeFilter).AddCriterion(odooclient.NewCriterion("id", "=", accountingContact.ParentId.Get())),
fetchPartnerFieldOpts)
if err != nil {
return odooclient.ResPartner{}, odooclient.ResPartner{}, fmt.Errorf("fetching parent %d of accounting contact %d failed: %w", accountingContact.ParentId.ID, id, err)
Expand Down Expand Up @@ -211,7 +211,7 @@ func (s *Odoo16Storage) List(ctx context.Context) ([]billingv1.BillingEntity, er
}
mp, ok := companySet[int(p.ParentId.ID)]
if !ok {
l.Info("could not load parent partner (maybe no longer active?)", "parent_id", p.ParentId.ID, "id", p.Id)
l.Info("could not load parent partner (maybe no longer active?)", "parent_id", p.ParentId.ID, "id", p.Id.Get())
continue
}
bes = append(bes, mapPartnersToBillingEntity(ctx, mp, p))
Expand Down

0 comments on commit 73a7e02

Please sign in to comment.