Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COVERAGE: Allow component management #1369

Closed
wants to merge 10 commits into from
Closed

Conversation

neolynx
Copy link
Member

@neolynx neolynx commented Oct 10, 2024

Fixes #

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 75.47931% with 243 lines in your changes missing coverage. Please review.

Project coverage is 74.89%. Comparing base (ae0fa20) to head (33404cc).

Files with missing lines Patch % Lines
api/publish.go 64.76% 97 Missing and 33 partials ⚠️
deb/publish.go 86.32% 24 Missing and 11 partials ⚠️
cmd/publish_source_add.go 77.46% 11 Missing and 5 partials ⚠️
cmd/publish_source_remove.go 74.60% 11 Missing and 5 partials ⚠️
cmd/publish_source_update.go 76.47% 11 Missing and 5 partials ⚠️
cmd/publish_source_drop.go 71.11% 9 Missing and 4 partials ⚠️
cmd/publish_source_list.go 79.68% 9 Missing and 4 partials ⚠️
cmd/publish_switch.go 90.00% 2 Missing ⚠️
cmd/publish_update.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1369      +/-   ##
==========================================
+ Coverage   74.87%   74.89%   +0.01%     
==========================================
  Files         151      156       +5     
  Lines       17144    18001     +857     
==========================================
+ Hits        12836    13481     +645     
- Misses       3286     3432     +146     
- Partials     1022     1088      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/publish_source_drop.go Outdated Show resolved Hide resolved
Christoph Fiehe and others added 7 commits October 11, 2024 15:53
This commit allows to add, remove and update components of published repositories without the need to recreate them.

Signed-off-by: Christoph Fiehe <[email protected]>
Signed-off-by: Christoph Fiehe <[email protected]>
Signed-off-by: Christoph Fiehe <[email protected]>
Signed-off-by: Christoph Fiehe <[email protected]>
Christoph Fiehe added 2 commits October 11, 2024 20:33
Signed-off-by: Christoph Fiehe <[email protected]>
api/publish.go Show resolved Hide resolved
deb/publish.go Show resolved Hide resolved
deb/publish.go Show resolved Hide resolved
@cfiehe cfiehe force-pushed the allow_component_management branch 4 times, most recently from 4ae501c to a005989 Compare October 12, 2024 19:42
Signed-off-by: Christoph Fiehe <[email protected]>
@neolynx neolynx closed this Oct 13, 2024
@neolynx neolynx deleted the allow_component_management branch October 13, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants