-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup files.PublishedStorage after dropping a publish #1381
base: master
Are you sure you want to change the base?
Conversation
@neolynx here is another annoying thing I'd like to fix in aptly. My publish prefix is bloated with empty directories as I have to create and remove publishes intensively. |
oh, yes please ! I found this quite annoying as well... |
yay, there is an issue for it! #198 |
527a843
to
ab96dc7
Compare
d5f937b
to
6809929
Compare
@neolynx original tests that were failing are now fixed, but my newly added PublishDrop21Test is failing, not sure why... May be it's time for me to learn something new, too? 😁 This alienish test suite is driving me nuts, frankly... |
05f0908
to
3b33303
Compare
All tests are passing now |
great ! could you explain why they failed ?
please do not judge :) the history of all of this is in git, many people worked on that. I think the thing to learn here is how to deal with legacy code and how to slowly improve it and revive the project. so please be respectful and constructive, we are all aware of the state of things, and it took months to get it to a working and halfway reliable state. |
-gold file was missing for my PublishDrop21Test - copied it from PublishDrop2Test. Not completely sure what it is. Whole experience of adding tests is cumbersome and non-obvious due to lack of developers documentation. Even some doc links to the testing frameworks would make the whole process more friendly and smooth... Oh, and original tests were failing because checks relied on empty directories now removed (as you said, the history of all of this is in git :-) ) |
ok great. in the Makefile there is the CAPTURE flag, you can uncomment, then the tests will create the gold files.
as said before, we are well aware of that. feel free to contribute. until then let's keep the discussions here technical.
thanks, that is excellent :-) |
ab0c5e5
to
81d0034
Compare
tests look good ! I started a coverage build: codecov/patch — 84.61% of diff hit (target 74.84%) |
5750df4
to
ddc84c5
Compare
Seems, ci is stuck again... |
seems we have a segfault: |
Heh, that's because nil is passed instead of P.S.: handled that on my side |
ddc84c5
to
268e056
Compare
Now, seems |
it needs that non empty check before remove... ;-) |
Also, something wrong with docker tests:
So, for me there is no simple way to update test now, unfortunately. |
You know what, my experience contributing in this particular PR is drastically falling down. Second day in a row we're chewing through tons of comments in a changeset that barely changes nothing, docs on testsuite are missing, tooling does not work and you're making jokes on me... That all really makes me sad. |
the docker-wrapper sets the user to the one of the git repo directory, to not write files as root. it seems your git dir is owned by root. changing to user owner would solve this in that case. |
not true
Thanks for the docker-wrapper idea, though. Slashed it a bit. |
268e056
to
0c9fe00
Compare
Re: better tooling #1384 It might be worth merging it first. |
A friendly ping for @neolynx Tests are fixed now. Let's finish those two PRs, we're on the homestretch ;) |
0c9fe00
to
33d5123
Compare
This comment was marked as resolved.
This comment was marked as resolved.
After dropping files.PublishedStorage there were some leftovers - empty directory tree. If that directory tree is empty, it is now removed. Fixes: aptly-dev#198
33d5123
to
3592987
Compare
Fixes: #198
After dropping files.PublishedStorage there were some leftovers - empty directory tree. If that directory tree is empty, it is now removed.
Checklist