-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move-stdlib] Use vector::move_range inside vector, and evaluate performance / calibrate gas #14862
Open
igor-aptos
wants to merge
12
commits into
igor/constant_serialized_size
Choose a base branch
from
igor/use_native_vector_move_range
base: igor/constant_serialized_size
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[move-stdlib] Use vector::move_range inside vector, and evaluate performance / calibrate gas #14862
igor-aptos
wants to merge
12
commits into
igor/constant_serialized_size
from
igor/use_native_vector_move_range
+3,528
−1,931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱️ 8h 45m total CI duration on this PR
🚨 1 job on the last run was significantly faster/slower than expected
|
8 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## igor/native_vector_move_range #14862 +/- ##
================================================================
Coverage ? 60.1%
================================================================
Files ? 858
Lines ? 211455
Branches ? 0
================================================================
Hits ? 127237
Misses ? 84218
Partials ? 0 ☔ View full report in Codecov by Sentry. |
igor-aptos
force-pushed
the
igor/native_vector_move_range
branch
from
October 4, 2024 16:59
75ebf46
to
d724063
Compare
igor-aptos
force-pushed
the
igor/use_native_vector_move_range
branch
from
October 4, 2024 17:00
0df908c
to
0fab436
Compare
igor-aptos
added
CICD:run-execution-performance-test
Run execution performance test
CICD:run-execution-performance-full-test
Run execution performance test (full version)
labels
Oct 4, 2024
igor-aptos
force-pushed
the
igor/use_native_vector_move_range
branch
from
October 4, 2024 22:36
0fab436
to
b1a2e70
Compare
8 tasks
igor-aptos
force-pushed
the
igor/native_vector_move_range
branch
from
October 8, 2024 19:00
d724063
to
e4540db
Compare
igor-aptos
force-pushed
the
igor/use_native_vector_move_range
branch
from
October 8, 2024 19:00
b1a2e70
to
6b493cd
Compare
igor-aptos
force-pushed
the
igor/native_vector_move_range
branch
from
October 9, 2024 20:30
e4540db
to
ae8e817
Compare
igor-aptos
force-pushed
the
igor/use_native_vector_move_range
branch
from
October 9, 2024 20:30
6b493cd
to
6046016
Compare
igor-aptos
force-pushed
the
igor/native_vector_move_range
branch
from
October 10, 2024 00:07
ae8e817
to
48df5f1
Compare
igor-aptos
force-pushed
the
igor/use_native_vector_move_range
branch
from
October 10, 2024 00:08
6046016
to
c5e50b3
Compare
igor-aptos
force-pushed
the
igor/native_vector_move_range
branch
from
October 10, 2024 18:09
48df5f1
to
1407c00
Compare
igor-aptos
force-pushed
the
igor/use_native_vector_move_range
branch
from
October 10, 2024 18:10
c5e50b3
to
36f8618
Compare
igor-aptos
force-pushed
the
igor/native_vector_move_range
branch
from
October 15, 2024 19:48
1407c00
to
94d1b68
Compare
igor-aptos
force-pushed
the
igor/use_native_vector_move_range
branch
from
October 15, 2024 19:48
36f8618
to
9851f51
Compare
igor-aptos
force-pushed
the
igor/native_vector_move_range
branch
from
October 16, 2024 21:07
94d1b68
to
51f1f1c
Compare
igor-aptos
force-pushed
the
igor/use_native_vector_move_range
branch
from
October 16, 2024 21:07
9851f51
to
3bcedb1
Compare
igor-aptos
force-pushed
the
igor/native_vector_move_range
branch
from
October 16, 2024 21:17
51f1f1c
to
b36187b
Compare
igor-aptos
force-pushed
the
igor/use_native_vector_move_range
branch
from
October 16, 2024 21:17
3bcedb1
to
a5af4dc
Compare
igor-aptos
force-pushed
the
igor/native_vector_move_range
branch
from
October 21, 2024 23:10
b36187b
to
5b9f388
Compare
igor-aptos
force-pushed
the
igor/use_native_vector_move_range
branch
from
October 21, 2024 23:10
a5af4dc
to
9fcf365
Compare
igor-aptos
force-pushed
the
igor/native_vector_move_range
branch
from
November 8, 2024 23:21
5b9f388
to
fc3c349
Compare
igor-aptos
force-pushed
the
igor/use_native_vector_move_range
branch
from
November 8, 2024 23:25
9fcf365
to
53920f9
Compare
igor-aptos
changed the base branch from
igor/native_vector_move_range
to
igor/constant_serialized_size
November 8, 2024 23:26
igor-aptos
force-pushed
the
igor/constant_serialized_size
branch
from
November 9, 2024 00:17
58152b4
to
c268f4a
Compare
igor-aptos
force-pushed
the
igor/use_native_vector_move_range
branch
from
November 9, 2024 00:17
53920f9
to
58c55c0
Compare
igor-aptos
force-pushed
the
igor/constant_serialized_size
branch
from
November 12, 2024 18:04
c268f4a
to
0c7a167
Compare
igor-aptos
force-pushed
the
igor/use_native_vector_move_range
branch
from
November 12, 2024 18:04
58c55c0
to
e1f971f
Compare
igor-aptos
force-pushed
the
igor/constant_serialized_size
branch
from
November 12, 2024 18:20
0c7a167
to
4b040df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CICD:run-execution-performance-full-test
Run execution performance test (full version)
CICD:run-execution-performance-test
Run execution performance test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use vector::move_range inside of vector, to optimize
insert
,remove
,append
,trim
.Extend aptos-move/e2e-benchmark/src/main.rs to track gas and gas/s, to allow for quick calibration.
Adding workloads to txn-emitter to be able to use it throughput.
Additionally add a missing
replace
method, which replaces value at particular index.Running on extended set of params:
https://gist.github.com/igor-aptos/e8d4e21edcbc75dddcb9382d4e077665
Summary of the performance tests:
For gas calibration, on the variety of workloads, current implementation has decent variance. After tuning params to match the averages, variance seems much smaller.
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist