Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix forge profiling link #15141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix forge profiling link #15141

wants to merge 1 commit into from

Conversation

aluon
Copy link
Contributor

@aluon aluon commented Oct 31, 2024

Description

Fix the links to the Forge CPU profiles. Grafana updated the pyroscope app and some of the parameters changed

How Has This Been Tested?

python3 -m unittest forge_test.py

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@aluon aluon requested review from ibalajiarun, perryjrandall and a team October 31, 2024 17:43
Copy link

trunk-io bot commented Oct 31, 2024

⏱️ 13m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 9m 🟩
rust-cargo-deny 2m 🟩
check-dynamic-deps 54s 🟩
general-lints 26s 🟩
semgrep/ci 26s 🟩
file_change_determinator 12s 🟩
determine-forge-run-metadata 4s 🟩🟩
permission-check 2s 🟩
permission-check 2s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants