-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[replay] Add transactions to skip for V2 loader #15207
base: george/parent-block-checks
Are you sure you want to change the base?
Conversation
⏱️ 274h 47m total CI duration on this PR
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @georgemitenkov and the rest of your teammates on Graphite |
@@ -175,8 +176,9 @@ impl Environment { | |||
) -> Self { | |||
// We compute and store a hash of configs in order to distinguish different environments. | |||
let mut sha3_256 = Sha3_256::new(); | |||
let features = | |||
let mut features = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: these overrides will be removed before landing
813cb54
to
c8cea5a
Compare
2a6d1a3
to
ff9cfad
Compare
0be5751
to
d4d1cbb
Compare
9f14964
to
acf39e9
Compare
d4d1cbb
to
f1d1b2b
Compare
acf39e9
to
23555ae
Compare
f1d1b2b
to
8397692
Compare
23555ae
to
313dd61
Compare
8397692
to
7dd77f1
Compare
313dd61
to
06bef4f
Compare
7dd77f1
to
1c90c20
Compare
06bef4f
to
d445b50
Compare
1c90c20
to
d2ce79d
Compare
d445b50
to
d47c538
Compare
d2ce79d
to
1275646
Compare
d47c538
to
e9c2544
Compare
1275646
to
ed7a2cc
Compare
e9c2544
to
4150eb9
Compare
ed7a2cc
to
4554fdd
Compare
4150eb9
to
50a8a18
Compare
4554fdd
to
6761e4d
Compare
50a8a18
to
2383b33
Compare
6761e4d
to
f2d8fd3
Compare
2383b33
to
f761fc2
Compare
f2d8fd3
to
0c55bd1
Compare
f761fc2
to
4ed9ce4
Compare
0c55bd1
to
c2bc38d
Compare
4ed9ce4
to
cbfaf50
Compare
c2bc38d
to
6989653
Compare
Description
There are well-known differences between existing loader and new loader & code cache, see here: https://docs.google.com/spreadsheets/d/16IVAe72g3Rcf3LqMKaj80a0Isa8ma3SaJFMVzOtVOfI/edit?usp=sharing. We should skip those.
Replay run: https://github.com/aptos-labs/aptos-core/actions/runs/11727539596
How Has This Been Tested?
Key Areas to Review
Type of Change
Which Components or Systems Does This Change Impact?
Checklist