Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[replay] Add transactions to skip for V2 loader #15207

Open
wants to merge 3 commits into
base: george/parent-block-checks
Choose a base branch
from

Conversation

georgemitenkov
Copy link
Contributor

@georgemitenkov georgemitenkov commented Nov 6, 2024

Description

There are well-known differences between existing loader and new loader & code cache, see here: https://docs.google.com/spreadsheets/d/16IVAe72g3Rcf3LqMKaj80a0Isa8ma3SaJFMVzOtVOfI/edit?usp=sharing. We should skip those.

Replay run: https://github.com/aptos-labs/aptos-core/actions/runs/11727539596

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @georgemitenkov and the rest of your teammates on Graphite Graphite

@georgemitenkov georgemitenkov changed the title [replay] Add tns to skip [replay] Add txns to skip Nov 6, 2024
@georgemitenkov georgemitenkov changed the title [replay] Add txns to skip [replay] Add txns to skip for V2 loader Nov 6, 2024
@georgemitenkov georgemitenkov changed the title [replay] Add txns to skip for V2 loader [replay] Add transactions to skip for V2 loader Nov 6, 2024
@georgemitenkov georgemitenkov marked this pull request as ready for review November 6, 2024 09:13
@georgemitenkov georgemitenkov requested a review from a team as a code owner November 6, 2024 09:13
@@ -175,8 +176,9 @@ impl Environment {
) -> Self {
// We compute and store a hash of configs in order to distinguish different environments.
let mut sha3_256 = Sha3_256::new();
let features =
let mut features =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: these overrides will be removed before landing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant