Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix transaction test failure #15235

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

yuunlimm
Copy link
Contributor

@yuunlimm yuunlimm commented Nov 7, 2024

Description

we were using a scripted txn for the test, but since this is submitted to localnet, we might get different txn_version for thist xn when it's resubmitted.

In this change, we replaced with imported txn, whose txn_version will never change.

How Has This Been Tested?

test passed

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 7, 2024

⏱️ 1h 11m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
rust-cargo-deny 9m 🟩🟩🟩
execution-performance / test-target-determinator 8m 🟩🟩
test-target-determinator 8m 🟩🟩
dispatch_event 8m 🟩
check 7m 🟩🟩
dispatch_event 6m 🟩
rust-doc-tests 5m 🟩
rust-doc-tests 5m 🟩
fetch-last-released-docker-image-tag 3m 🟩🟩
check-dynamic-deps 2m 🟩🟩🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
rust-move-tests 2m 🟩
general-lints 1m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
rust-cargo-deny 5m 2m +187%

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor Author

yuunlimm commented Nov 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @yuunlimm and the rest of your teammates on Graphite Graphite

@yuunlimm yuunlimm marked this pull request as ready for review November 7, 2024 22:31
@yuunlimm yuunlimm enabled auto-merge (squash) November 7, 2024 22:46

This comment has been minimized.

This comment has been minimized.

@yuunlimm yuunlimm force-pushed the 11-07-fix_transaction_test_failure branch from 8cefb80 to 5bc872c Compare November 7, 2024 23:06

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

✅ Forge suite realistic_env_max_load success on 5bc872cde5a40a59991dd9cc222313ac289d846f

two traffics test: inner traffic : committed: 14513.33 txn/s, latency: 2739.96 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3000 ms), latency samples: 5518460
two traffics test : committed: 99.89 txn/s, latency: 1375.44 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 1700 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 2.005, avg: 1.565", "ConsensusProposalToOrdered: max: 0.319, avg: 0.292", "ConsensusOrderedToCommit: max: 0.380, avg: 0.359", "ConsensusProposalToCommit: max: 0.674, avg: 0.651"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.85s no progress at version 2921623 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.70s no progress at version 2919384 (avg 8.70s) [limit 15].
Test Ok

Copy link
Contributor

github-actions bot commented Nov 7, 2024

✅ Forge suite compat success on 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 5bc872cde5a40a59991dd9cc222313ac289d846f

Compatibility test results for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 5bc872cde5a40a59991dd9cc222313ac289d846f (PR)
1. Check liveness of validators at old version: 1086a5e00d773704731ab84fb4ed3538613b2250
compatibility::simple-validator-upgrade::liveness-check : committed: 17042.38 txn/s, latency: 1963.88 ms, (p50: 1900 ms, p70: 2100, p90: 2300 ms, p99: 2800 ms), latency samples: 551540
2. Upgrading first Validator to new version: 5bc872cde5a40a59991dd9cc222313ac289d846f
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 8087.93 txn/s, latency: 3566.71 ms, (p50: 4000 ms, p70: 4100, p90: 4300 ms, p99: 4400 ms), latency samples: 148280
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 8199.59 txn/s, latency: 3924.55 ms, (p50: 4200 ms, p70: 4300, p90: 4500 ms, p99: 5000 ms), latency samples: 272140
3. Upgrading rest of first batch to new version: 5bc872cde5a40a59991dd9cc222313ac289d846f
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7606.08 txn/s, latency: 3770.63 ms, (p50: 4200 ms, p70: 4400, p90: 4600 ms, p99: 4700 ms), latency samples: 141620
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7511.26 txn/s, latency: 4283.10 ms, (p50: 4600 ms, p70: 4700, p90: 5300 ms, p99: 5800 ms), latency samples: 249860
4. upgrading second batch to new version: 5bc872cde5a40a59991dd9cc222313ac289d846f
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 12527.11 txn/s, latency: 2204.73 ms, (p50: 2400 ms, p70: 2500, p90: 2600 ms, p99: 2700 ms), latency samples: 218860
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10123.49 txn/s, latency: 3095.84 ms, (p50: 2700 ms, p70: 3100, p90: 6100 ms, p99: 8200 ms), latency samples: 364860
5. check swarm health
Compatibility test for 1086a5e00d773704731ab84fb4ed3538613b2250 ==> 5bc872cde5a40a59991dd9cc222313ac289d846f passed
Test Ok

@yuunlimm yuunlimm merged commit 8674bbd into main Nov 7, 2024
49 checks passed
@yuunlimm yuunlimm deleted the 11-07-fix_transaction_test_failure branch November 7, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants