Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Implement generic comparison method in move - move part (cmp::compare) #15245

Open
wants to merge 1 commit into
base: igor/enable_move_2_for_framework
Choose a base branch
from

Conversation

igor-aptos
Copy link
Contributor

Description

Separated out move part of the cmp::compare native call (first part is in the #14714), as it requires enums, and can only land after enums are enabled.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Nov 8, 2024

⏱️ 18m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-cargo-deny 4m 🟩🟩🟥
rust-move-tests 4m 🟥
rust-move-tests 3m 🟥
check-dynamic-deps 2m 🟩🟩🟩
general-lints 2m 🟩🟩🟩
semgrep/ci 1m 🟩🟩🟩
rust-move-tests 33s 🟥
file_change_determinator 33s 🟩🟩🟩
permission-check 13s 🟩🟩🟩
permission-check 8s 🟩🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants