Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IGNORE] Test #15253

Closed
wants to merge 19 commits into from
Closed

[IGNORE] Test #15253

wants to merge 19 commits into from

Conversation

georgemitenkov
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

@georgemitenkov
[refactoring] Move explicit sync wrapper to aptos-types
977f5c3
@georgemitenkov
[refactoring] Move & rename immutabke module cache to aptos-types
bafe3f0
@georgemitenkov
[global cache] Draft e2e implementation
70d5156
@georgemitenkov
[testing] Added different test cases for global caches
c9cd3ca
@georgemitenkov
[perf] Framework prefetch
ed41eef
@georgemitenkov
[exp] Avoid repeated arcswap load
7cc9fe7
@georgemitenkov
[cleanup] Add errors, documentation, reset state on panics
82868eb
@georgemitenkov
[refactoring] Remove versions from module code
f11ae25
@georgemitenkov
[comments] Addressing Rati's comments + adding size in bytes to modul…
94542c7 
…e cache
@georgemitenkov
[draft] Better states and encapsulation
4facf77
@georgemitenkov
prior to addressing comments:
0e68139 
  - Fixed a bug where on successful marking as executing we were re-creating environment
  - Removed optional manager in BlockAptosVM, instead a new instance can be provided
  - Removed clean state, instead manager is initialized to Done(None) and optional values
    need to be provided.
@georgemitenkov
[comments] Address Rati's and Zekun's comments
ed8018f
@georgemitenkov
[fix] Add done --> ready transition for unit tests
04a2733
@georgemitenkov
Move ready checks to cache manager, better encapsulation by passing h…
eee36d5 
…ash values throughout
@georgemitenkov
[cleanup] Set execute_no_limit to always use Nones for block IDs
63040f3
@georgemitenkov
Feature gating
f190968
@georgemitenkov
[move] Enable V2 loader
dad3319
@georgemitenkov
[replay] Reset replay timeouts back
cd3a251
@georgemitenkov
addr, name --> module_id
2638f8a
@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 12, 2024 •
edited
Loading

⏱️ 2h 31m total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
execution-performance / single-node-performance 1h 55m 🟥 🟥 🟥 
execution-performance / test-target-determinator 13m 🟩 🟩 🟩 
rust-move-tests 9m 🟩 
check-dynamic-deps 5m 🟩 🟩 🟩 
test-target-determinator 5m 🟩 
rust-cargo-deny 2m 🟩 
semgrep/ci 1m 🟩 🟩 🟩 
general-lints 25s 🟩 
permission-check 14s 🟩 🟩 🟩 
file_change_determinator 13s ⬜ 🟩 
file_change_determinator 11s 🟩 
determine-test-metadata 10s 🟩 
permission-check 7s 🟩 🟩 🟩 
permission-check 3s 🟩 
determine-docker-build-metadata 2s 🟩 

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 40m 18m +125%
check-dynamic-deps 2m 1m +101%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@georgemitenkov georgemitenkov added CICD:run-execution-performance-test Run execution performance test CICD:run-execution-performance-full-test Run execution performance test (full version) labels Nov 12, 2024
@georgemitenkov georgemitenkov deleted the george/enable-loader-v2-with-module-ids branch November 12, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmouse msmouse Awaiting requested review from msmouse msmouse will be requested when the pull request is marked ready for review msmouse is a code owner

@lightmark lightmark Awaiting requested review from lightmark lightmark will be requested when the pull request is marked ready for review lightmark is a code owner

@grao1991 grao1991 Awaiting requested review from grao1991 grao1991 will be requested when the pull request is marked ready for review grao1991 is a code owner

@gelash gelash Awaiting requested review from gelash gelash will be requested when the pull request is marked ready for review gelash is a code owner

@runtian-zhou runtian-zhou Awaiting requested review from runtian-zhou runtian-zhou will be requested when the pull request is marked ready for review runtian-zhou is a code owner

@sasha8 sasha8 Awaiting requested review from sasha8 sasha8 will be requested when the pull request is marked ready for review sasha8 is a code owner

@danielxiangzl danielxiangzl Awaiting requested review from danielxiangzl danielxiangzl will be requested when the pull request is marked ready for review danielxiangzl is a code owner

@zekun000 zekun000 Awaiting requested review from zekun000 zekun000 will be requested when the pull request is marked ready for review zekun000 is a code owner

@davidiw davidiw Awaiting requested review from davidiw davidiw will be requested when the pull request is marked ready for review davidiw is a code owner

@movekevin movekevin Awaiting requested review from movekevin movekevin will be requested when the pull request is marked ready for review movekevin is a code owner

@wrwg wrwg Awaiting requested review from wrwg wrwg will be requested when the pull request is marked ready for review wrwg is a code owner

@vgao1996 vgao1996 Awaiting requested review from vgao1996 vgao1996 will be requested when the pull request is marked ready for review vgao1996 is a code owner

Assignees
No one assigned
Labels
CICD:run-execution-performance-full-test Run execution performance test (full version) CICD:run-execution-performance-test Run execution performance test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@georgemitenkov