Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network] Add simple queuing metrics for message sends. #15268

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

JoshLind
Copy link
Contributor

@JoshLind JoshLind commented Nov 13, 2024

Description

This PR adds simple queuing metrics to the network stack. Specifically, metrics for tracking the time between when a message is sent by the application (after serialization), until when it is finally written to the network wire.

The next set of PRs will include: (i) receiver side metrics; and (ii) support for messages with embedded timestamps for tracking transport times.

Testing Plan

Existing test infrastructure.

Copy link

trunk-io bot commented Nov 13, 2024

⏱️ 3h total CI duration on this PR
Slowest 15 Jobs Cumulative Duration Recent Runs
test-target-determinator 45m 🟩🟩🟩🟩🟩 (+6 more)
check-dynamic-deps 20m 🟩🟩🟩🟩🟩 (+7 more)
rust-cargo-deny 20m 🟩🟩🟩🟩🟩 (+7 more)
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 10m 🟩
rust-move-tests 9m 🟩
rust-move-tests 9m 🟩
rust-move-tests 7m 🟥
rust-move-tests 7m
semgrep/ci 6m 🟩🟩🟩🟩🟩 (+7 more)
general-lints 6m 🟩🟩🟩🟩🟩 (+7 more)
rust-move-tests 3m 🟥
file_change_determinator 3m 🟩🟩🟩🟩🟩 (+7 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

@JoshLind JoshLind added the CICD:run-forge-e2e-perf Run the e2e perf forge only label Nov 13, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@JoshLind JoshLind force-pushed the net_queue_lat branch 2 times, most recently from 3910c19 to 8522b5a Compare November 14, 2024 03:26

This comment has been minimized.

This comment has been minimized.

@JoshLind JoshLind force-pushed the net_queue_lat branch 2 times, most recently from 18ffd3d to 669a73e Compare November 14, 2024 18:11

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@JoshLind JoshLind force-pushed the net_queue_lat branch 2 times, most recently from e1e55b2 to 8589444 Compare November 15, 2024 01:50

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

❌ Forge suite realistic_env_max_load failure on d586e08aa96914d727927bd26c61971f848c0f4d

Forge test runner terminated:
Trailing Log Lines:
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
  34: std::panicking::try
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
  35: std::panic::catch_unwind
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
  36: std::rt::lang_start_internal
             at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/rt.rs:148:20
  37: main
  38: __libc_start_main
  39: _start
Debugging output:
NAME                                    READY   STATUS             RESTARTS       AGE
aptos-node-0-fullnode-eforge105-0       0/1     CrashLoopBackOff   3 (37s ago)    2m11s
aptos-node-0-validator-0                1/1     Running            0              15s
aptos-node-1-fullnode-eforge105-0       0/1     CrashLoopBackOff   5 (104s ago)   7m9s
aptos-node-1-validator-0                0/1     CrashLoopBackOff   4 (32s ago)    3m31s
aptos-node-2-fullnode-eforge105-0       1/1     Running            5 (87s ago)    4m27s
aptos-node-2-validator-0                0/1     CrashLoopBackOff   5 (95s ago)    7m9s
aptos-node-3-fullnode-eforge105-0       1/1     Running            3 (37s ago)    95s
aptos-node-3-validator-0                0/1     PodInitializing    0              40s
aptos-node-4-fullnode-eforge105-0       1/1     Running            1 (4s ago)     46s
aptos-node-4-validator-0                0/1     Error              5 (107s ago)   4m27s
aptos-node-5-validator-0                0/1     CrashLoopBackOff   3 (32s ago)    2m17s
aptos-node-6-validator-0                0/1     CrashLoopBackOff   3 (31s ago)    116s
genesis-aptos-genesis-eforge105-n6lkd   0/1     Completed          0              7m11s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CICD:run-forge-e2e-perf Run the e2e perf forge only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant