[bcs] Add deserialization of RawTransactionWithData #41
+124
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregnazario
force-pushed
the
add-raw-transaction-with-data-deserialize
branch
from
b70e15f
to
df08ec4
Compare
GhostWalker562
approved these changes
Nov 7, 2024
banool
approved these changes
Nov 8, 2024
Comment on lines
+83
to
+88
| if enum_type == 0: | ||
| return MultiAgentRawTransaction.deserialize_inner(deserializer) | ||
| elif enum_type == 1: | ||
| return FeePayerRawTransaction.deserialize_inner(deserializer) | ||
| else: | ||
| raise Exception("Unhandled RawTransaction enum type") |
There was a problem hiding this comment.
Slightly spooky, vs making use of bindings or whatever, but I guess the whole Python SDK is like this lol so it's alright. Since these magic numbers appear multiple times some constants could be good at least.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was requested for cross language support of SDKs
Test Plan
Related Links