Use local network with tests #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmaayan
requested review from
gregnazario,
0xmigo,
heliuchuan and
a team
as code owners
|
This is so great, huge props again to @banool !! |
gregnazario
approved these changes
Oct 12, 2023
tests/e2e/api/account.test.ts
Outdated
| const accountCoinData = await aptos.getAccountCoinsData({ | ||
| accountAddress: senderAccount.accountAddress.toString(), | ||
| }); | ||
| expect(accountCoinData[0].amount).toBe(100000000); |
There was a problem hiding this comment.
Should move to a constant, maybe even a default fund amount, at least for testing
Comment on lines
+69
to
+70
| // to help with indexer latency | ||
| await sleep(1000); |
There was a problem hiding this comment.
Summarizing what I said in Slack, it'd be better to look at the txn version from the committed txn output and then wait for the indexer to catch up to that version by querying the processor status. That'd have the least latency and be fully reliable.
Comment on lines
+505
to
+508
| const config = new AptosConfig({ network: Network.LOCAL }); | ||
| const aptos = new Aptos(config); | ||
| const alice = Account.generate({ scheme: SigningScheme.Ed25519 }); | ||
| await aptos.fundAccount({ accountAddress: alice.accountAddress.toString(), amount: 1000000000 }); |
There was a problem hiding this comment.
We should probably at a minimum put this duplicated code in a function
0xmaayan
force-pushed
the
use_localnet_on_tests
branch
from
f9712f0
to
6cc9243
Compare
0xmaayan
force-pushed
the
use_localnet_on_tests
branch
from
6cc9243
to
6ecd477
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change tall tests to use local network.
@banool do we need docker in CI?
There is a latency chance when querying indexer right after we submit a transaction, therefore adding
sleep(100)- can think about a different approach for our test framework we want to have or in a following PR.Test Plan
Related Links