Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ABC Wallet] Support ABC Wallet #396

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

bryan-ahnlab
Copy link

This pull request contains the support of ABC Wallet.

@bryan-ahnlab bryan-ahnlab changed the title [ABC Wallet] Support ABC Wallet #395 [ABC Wallet] Support ABC Wallet Aug 12, 2024
Copy link
Collaborator

@0xmaayan 0xmaayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run pnpm run changeset to include these changes in the next release
https://github.com/aptos-labs/aptos-wallet-adapter/blob/main/CONTRIBUTING.md#changesets

pnpm-lock.yaml Outdated Show resolved Hide resolved
.changeset/funny-seas-sin.md Outdated Show resolved Hide resolved
.changeset/funny-seas-sin.md Outdated Show resolved Hide resolved
@aptos-labs aptos-labs deleted a comment from oamhen11 Aug 22, 2024
@aptos-labs aptos-labs deleted a comment from oamhen11 Aug 22, 2024
@kent-white kent-white enabled auto-merge (squash) August 22, 2024 17:51
@kent-white kent-white self-requested a review August 22, 2024 21:35
@kent-white
Copy link
Contributor

We are worried about this wallet showing up on desktop, when its not available on desktop.

We may need to introduce another commit that hides non-desktop wallets from desktop surfaces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants