Simplify GetMapsIDsByName #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @aymericDD. Could you please explain this weird behaviour so we can provide more context for this change. |
|
When I was using a BPF_MAP_TYPE_HASH with a struct key and struct value, the map was not returned in the list of IDs. I take a look at the bpftool and I notice the ID was not re-incremented manually. |
|
I added a unit test to cover this case. I don't have a local dev environment because I have a Macbook pro M1 and vagrant with virtualbox is not supported for now with the ARM architecture. |
geyslan
reviewed
Oct 11, 2023
It retrieves the next available map ID after the given startID.
geyslan
reviewed
Oct 20, 2023
Remove custom error to reduce maintenance toil. Just return the syscall error is enough and does not ask to create custom error for each kind of syscall errors.
geyslan
reviewed
Oct 20, 2023
The startId was not a pointer, so its value was never updated for the caller of the GetMapsIDsByName function.
aymericDD
force-pushed
the
fix/GetMapsIdsByName
branch
from
af36d23
to
09f8e66
Compare
|
@aymericDD is it waiting review? |
|
Yes 👍 |
|
@aymericDD thanks again for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
idis incremented byC.bpf_map_get_next_idso no need to define thestartIdandnextId. I encounter some weird behavior in my project when I was using map with a BPF_MAP_TYPE_HASH type.