Develop #13
Closed
Develop #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove ts-node and build the project to javascript
Add MailDev in docker-compose
The zod schema will ensure that the ENV config is valid thanks to a zod schema. It will also improve the DX thanks to the typed export `env` from `src/env.ts`.
This .env.example is also used to create the base .env, when the server does not find an existing .env file
[IMPROVE] Ensure the ENV variables are valid
[FEAT] use jose instead of jsonwebtoken
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/app.ts
Outdated
|
|
||
| app.use(express.json({limit: '50mb'})); | ||
| app.use(express.urlencoded({limit: '50mb' ,extended: false})); | ||
| app.use(cookieParser()); |
Check failure
Code scanning / CodeQL
Missing CSRF middleware
src/app.ts
Outdated
Comment on lines
51
to
119
| app.all('*', function (req, res, next) { | ||
| if (req.path === '/users/login' || req.path === '/users') { | ||
| next(); | ||
| } else { | ||
| const { application_token} = req.headers; | ||
| if(application_token && typeof application_token === "string") { | ||
| jwt.verify(application_token, env.APPLICATION_TOKEN_SECRET) | ||
| .then((decoded) => { | ||
| ApplicationModel.findOne({ | ||
| where: { | ||
| token: req.headers.application_token, | ||
| }, | ||
| }) | ||
| .then((application) => { | ||
| // decoded cannot be a string since the | ||
| // token is generated from an object | ||
| if (application && typeof decoded !== "string") { | ||
| req.user = new UserDto(decoded.user); | ||
| next(); | ||
| } else { | ||
| res.status(401).send({ | ||
| message: "Invalid application token", | ||
| }); | ||
| } | ||
| }) | ||
| .catch((err) => { | ||
| res.status(500).send({ | ||
| message: "Internal server error", | ||
| }); | ||
| }); | ||
| }) | ||
| .catch((err) => { | ||
| console.log(err); | ||
| res.status(401).send({ | ||
| message: "Invalid application token", | ||
| }); | ||
| }); | ||
| } else { | ||
| jwt.verify(req.cookies.access_token, env.ACCESS_TOKEN_SECRET) | ||
| .then(decoded => { | ||
| req.user = new UserDto(decoded); | ||
| next(); | ||
| }) | ||
| .catch((err) => { | ||
| jwt.verify(req.cookies.refresh_token, env.REFRESH_TOKEN_SECRET) | ||
| .then((user) => { | ||
| UserModel.findByPk(user.id) | ||
| .then(async function (user) { | ||
| if (user) { | ||
| res.cookie('access_token', await UserTokenUtil.generateAccessToken(new UserDto(user)), {maxAge: 1000 * 60 * 30}); | ||
| res.cookie('refresh_token', req.cookies.refresh_token, {maxAge: 1000 * 60 * 60 * 24 * 30}); | ||
| req.user = new UserDto(user); | ||
| next(); | ||
| } else { | ||
| res.status(401).send(); | ||
| } | ||
| }) | ||
| .catch(function (err) { | ||
| res.status(401).send(); | ||
| }); | ||
| }) | ||
| .catch((err) => { | ||
| res.status(401).send(); | ||
| }); | ||
|
|
||
| }) | ||
| } | ||
| } | ||
| }); |
Check failure
Code scanning / CodeQL
Missing rate limiting
[IMPROVEMENT] use typescript strict mode
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required :