Added Russian translation. Added credits to translators. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanaya
commented
Apr 19, 2020
| @@ -23,7 +23,7 @@ const LanguageScreen = ({ navigation }: Props) => { | |||
| <> | |||
| <Vertical unit={0.5} /> | |||
| <CtaButton | |||
| onPress={() => navigation.navigate('Home')} | |||
| onPress={() => navigation.navigate('Welcome')} | |||
There was a problem hiding this comment.
This is an important bug fix introduced after the changes for restyling this screen. This button should redirect to the Welcome Screen to start the setup process, not to the Home Screen with the links. Sorry about that.
There was a problem hiding this comment.
Yeah. I fixed this just earlier. Thankfully I noticed the regression since I was about to publish an upgrade :)
No worries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Russian following #58:
Added credits to translators:
